Use cmath functions in kernels/portable#17092
Merged
zingo merged 2 commits intopytorch:mainfrom Feb 3, 2026
Merged
Conversation
Signed-off-by: Zingo Andersen <[email protected]> Change-Id: If0f90e8e9ea7eff5dd717a460ca71337e0b6066c
zingo
added
the
partner: arm
zingo
added
ciflow/trunk
release notes: none
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17092
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 893e4c6 with merge base 059c729 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
Hi @SS-JIA here is a generic PR that is the result of a review comment from @mergennachin in #16340 to handle more cases where std:: was missing :) |
SS-JIA
approved these changes
Feb 2, 2026
Contributor
SS-JIA
left a comment
SS-JIA
left a comment
There was a problem hiding this comment.
LGTM; cc: @manuelcandales since this is related to kernel libraries
mergennachin
approved these changes
Feb 2, 2026
Contributor
mergennachin
left a comment
mergennachin
left a comment
There was a problem hiding this comment.
Thank you for following up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @freddan80 @per @oscarandersson8218 @digantdesai